Smart Contract Upgrades

General
1

Overview

I am requesting support from the community for the following upgrades to the Seamless Protocol smart contracts. I am also requesting to fast track this post if it receives the necessary community support.

Upgrade 1 - Lending Pool Implementation

A member of the Aave community, BGD Labs, has privately reached out to certain Seamless contributors to notify them of a potential issue with the Aave lending pool implementation. No Seamless funds are currently at risk but we should never the less apply this fix as part of the Seamless community’s commitment to security.

As the details of the fix have not been yet been publicly disclosed, I will simply link relevant the relevant past Aave governance discussion here.

Technical details:

  • New lending pool implementation is deployed and verified. Basecan link
  • Governance should execute the setPoolImpl function on the PoolAddressesProvider contract. Basescan link

Upgrade 2 - Price Oracle Sentinel

Seamless Protocol users have periodically reported errors when borrowing, they sometimes receive error code 59. This error code is supposed to indicate that the Base L2 sequencer has failed it’s health check (i.e.: it is currently down), reference. Seamless contributors have discovered a bug such that the Price Oracle Sentinel thinks the sequencer is down when it is in fact not down. More details can be found in this Github issue.

Technical details:

  • New price oracle sentinel is deployed and verified. Basescan link
  • Governance should execute the setPriceOracleSentinel function on the PoolAddressesProvider contract. Basescan link
2 Likes
2

These are good fixes/upgrades. I am in support of applying them, along with a fast track proposal.

3

Given this is a known and solved issue - am in favor of this upgrade occuring.

Makes sense to bundle in the price oracle sentinel fix as well.

Am supportive of a fast track approach

4

It’s an amazing idea to fix the price oracle, and these upgrades will help ensure a more robust and efficient system for all users. Thank you for prioritizing these!

5

I am in alignment with the proposed changes as they seem reasonable for the health of the protocol. Thanks for raising – and agree on fast track as well to ensure swift updates.

6

We should follow BGD labs on this one. They are core contributors from early days of Aave. Complete support on this proposal from my side and I think we should go with this one asap.

7

Better safe than sorry. Security first and foremost.

I’m in favor of this prooposal.

8

Security is the most important issue. In support of this proposal and the fast track

9

The proposal has been created onchain, voting starts in 48 hours. Tally | Seamless Protocol Proposal

1 Like